From 339fed1585344a212464243cf4da517272ce3a9c Mon Sep 17 00:00:00 2001 From: Eli Polonsky Date: Thu, 14 Nov 2024 16:31:40 +0200 Subject: [PATCH] chore(contributing): mention manual PR merge option (#32126) Folks are probably already doing this, but just clarify that when a PR is failing status checks you can ping a maintainer for a manual merge if you think its justified. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 81dfff28ae4ce..98f02c5fa0f92 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -804,6 +804,11 @@ console.log('This cannot be covered') * Once approved and tested, one of our bots will squash-merge to main and will use your PR title/description as the commit message. +> [!NOTE] +> If your PR is failing one of the required checks (e.g Codecov), it will not be auto-merged. If you believe the PR should be merged +> inspite of this, let a maintainer know. The maintainer may agree and merge the PR manually, or ask you to address the failing checks. + + ## Breaking Changes **_NOTE_**: _Starting with version 2.0.0 of the AWS CDK, **all modules and members vended as part of the main CDK library**_