Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(events-targets): Add target class for API Gateway target in EventBridge #12708

Closed
hugomallet opened this issue Jan 26, 2021 · 2 comments · Fixed by #13823
Closed

(events-targets): Add target class for API Gateway target in EventBridge #12708

hugomallet opened this issue Jan 26, 2021 · 2 comments · Fixed by #13823
Assignees
@rix0rrr
Labels
@aws-cdk/aws-events-targets effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2

Comments

@hugomallet
Copy link

Hi,

The API Gateway target is missing from the events-targets module.

This target is available in EventBridge as described here : https://docs.aws.amazon.com/eventbridge/latest/userguide/targets-apigateway.html
And in cloudformation (HttpParameters) : https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-events-rule-target.html#cfn-events-rule-target-httpparameters

(For future readers : AwsApi target class is not related to api gateway !)

Can you add this target ?

Thanks,

This is a 🚀 Feature Request
@hugomallet hugomallet added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 26, 2021
@hugomallet hugomallet mentioned this issue Jan 26, 2021
Closed
@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p2 labels Jan 27, 2021
@hedrall
Copy link
Contributor

hedrall commented Mar 22, 2021

I’d like to work on it.

@hedrall hedrall mentioned this issue Mar 26, 2021
Merged
@mergify mergify bot closed this as completed in #13823 Apr 23, 2021
mergify bot pushed a commit that referenced this issue Apr 23, 2021
@hedrall
feat(events): API Gateway target (#13823)
ce789bf 
close #12708 

Added construct class of api gateway target .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this issue May 10, 2021
@hedrall @john-tipper
feat(events): API Gateway target (aws#13823)
a77523a 
close aws#12708 

Added construct class of api gateway target .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@hedrall @hollanddd
feat(events): API Gateway target (aws#13823)
0760994 
close aws#12708 

Added construct class of api gateway target .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-events-targets effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(events): API Gateway target hedrall/aws-cdk
3 participants
@rix0rrr @hugomallet @hedrall