Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK integration tests are broken due to invalid newline handling in python sample code #13035

Closed
eladb opened this issue Feb 14, 2021 · 1 comment · Fixed by #13036 or #13038
Closed

CDK integration tests are broken due to invalid newline handling in python sample code #13035

eladb opened this issue Feb 14, 2021 · 1 comment · Fixed by #13036 or #13038
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@eladb
Copy link
Contributor

eladb commented Feb 14, 2021 •
edited
Loading

One of our lambda integration tests uses \n inside a string literal which is mishandled by the jsii sample code transcoder for python (rosetta): See aws/jsii#2569

This is 🐛 Bug Report
@eladb eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 14, 2021
eladb pushed a commit that referenced this issue Feb 14, 2021
chore(lambda): invalid python sample code generated
f0372af 
jsii-rosettta has a bug which renders invalid python when a newline is included in a string literal. Remove that string literal for now.

Fixes #13035
@eladb eladb mentioned this issue Feb 14, 2021
Merged
@mergify mergify bot closed this as completed in #13036 Feb 14, 2021
mergify bot pushed a commit that referenced this issue Feb 14, 2021
chore(lambda): invalid python sample code generated (#13036)
fd808b4 
jsii-rosettta has a bug which renders invalid python when a newline is included in a string literal. Remove that string literal for now.

Fixes #13035


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

eladb pushed a commit that referenced this issue Feb 14, 2021
chore(lambda): invalid python sample code generated
5ec40f7 
Following up on #13036 with an additional instance in which rosetta fails to generate correct python code.

Fixes #13035
@eladb eladb mentioned this issue Feb 14, 2021
Merged
mergify bot pushed a commit that referenced this issue Feb 14, 2021
chore(lambda): invalid python sample code generated (#13038)
bef0e84 
Following up on #13036 with an additional instance in which rosetta fails to generate correct python code (aws/jsii#2569).

Fixes #13035


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this issue Feb 18, 2021
@NovakGu
chore(lambda): invalid python sample code generated (aws#13036)
b548b54 
jsii-rosettta has a bug which renders invalid python when a newline is included in a string literal. Remove that string literal for now.

Fixes aws#13035


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this issue Feb 18, 2021
@NovakGu
chore(lambda): invalid python sample code generated (aws#13038)
59fb042 
Following up on aws#13036 with an additional instance in which rosetta fails to generate correct python code (aws/jsii#2569).

Fixes aws#13035


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
1 participant
@eladb