Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@aws-cdk/aws-iam): SAML provider name is not output #14294

Closed
14kw opened this issue Apr 21, 2021 · 1 comment · Fixed by #14296
Closed

(@aws-cdk/aws-iam): SAML provider name is not output #14294

14kw opened this issue Apr 21, 2021 · 1 comment · Fixed by #14296
Assignees
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@14kw
Copy link
Contributor

14kw commented Apr 21, 2021

Reproduction Steps

    new iam.SamlProvider(this, 'Provider', {
      metadataDocument: iam.SamlMetadataDocument.fromXml('document'),
      name: 'provider-name'
    });

What did you expect to happen?

Resources:
  Provider2281708E:
    Type: AWS::IAM::SAMLProvider
    Properties:
      SamlMetadataDocument: document
      Name: provider-name
    Metadata:
      aws:cdk:path: CdkTestStack/Provider/Resource

What actually happened?

Name property is missing.

Resources:
  Provider2281708E:
    Type: AWS::IAM::SAMLProvider
    Properties:
      SamlMetadataDocument: document
    Metadata:
      aws:cdk:path: CdkTestStack/Provider/Resource

Environment

  • CDK CLI Version : 1.100.0
  • Framework Version: 1.100.0
  • Node.js Version: v15.4.0
  • OS : macOS Catalina 10.15.7
  • Language (Version): Typescript 3.9.9, Python 3.8.1

Other


This is 🐛 Bug Report

@14kw 14kw added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Apr 21, 2021
@mergify mergify bot closed this as completed in #14296 Apr 21, 2021
mergify bot pushed a commit that referenced this issue Apr 21, 2021
By passing the SAML provider name property, the Name property will be output to the template.

fixes #14294

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this issue May 10, 2021
By passing the SAML provider name property, the Name property will be output to the template.

fixes aws#14294

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
By passing the SAML provider name property, the Name property will be output to the template.

fixes aws#14294

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants