Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pipelines): Enable KMS Key rotation for pipeline #16813

Closed
2 tasks
xeroxnir opened this issue Oct 6, 2021 · 2 comments
Closed
2 tasks

(pipelines): Enable KMS Key rotation for pipeline #16813

xeroxnir opened this issue Oct 6, 2021 · 2 comments
Labels
@aws-cdk/pipelines CDK Pipelines library closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@xeroxnir
Copy link

xeroxnir commented Oct 6, 2021

Description

CodePipeline supports key rotation with enableKeyRotation prop.

Would be great to have the same property on the pipeline construct.

Use Case

Enable rotation security best practice (also fix cfn_nag findings)

Proposed Solution

Pass enableKeyRotation prop to the CodePipeline construct (similar to crossAccountKey).

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@xeroxnir xeroxnir added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 6, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Oct 6, 2021
@rix0rrr rix0rrr changed the title (pipeline): Enable KMS Key rotation for pipeline (pipelines): Enable KMS Key rotation for pipeline Oct 6, 2021
@rix0rrr rix0rrr assigned rix0rrr and unassigned skinny85 Oct 6, 2021
@rix0rrr rix0rrr added @aws-cdk/pipelines CDK Pipelines library and removed @aws-cdk/aws-codepipeline Related to AWS CodePipeline labels Oct 6, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Oct 6, 2021
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed @aws-cdk/aws-codepipeline Related to AWS CodePipeline needs-triage This issue or PR still needs to be triaged. labels Oct 6, 2021
@rix0rrr rix0rrr removed their assignment Oct 6, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 6, 2021

For now, construct your own codepipeline.Pipeline, configure it as you wish, and pass that into the CodePipeline.

In general, not sure if this case wouldn't be better served by a mechanism like proposed here: aws/aws-cdk-rfcs#25

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/pipelines CDK Pipelines library closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skinny85 @rix0rrr @xeroxnir