-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docdb): add option to set the name of the generated Secret #17574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @markussiebert!
The code looks good, we're just missing two things:
- Documentation in the ReadMe file of the module showing usage of this property (a one-line change to example code with a comment in the file is fine).
- Unit tests (you can look at the existing unit tests in the module for inspiration).
Thanks,
Adam
Pull request has been modified.
@skinny85 sorry - don't know how to ask for a review the official way |
For the future 🙂. You need to re-request my review (there's a button right next to my avatar in the top-right corner of the Pull Request web page). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @markussiebert, thanks for the contribution!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes: #17572
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license