Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stack account id throws error if not a string #25134

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

vinayak-kukreja
Copy link
Contributor

If the account id passed in as stack environment is not a string, then that leads to errors in some lookup functions. This PR is adding a type check for stack's account id and region. These are only allowed to be string datatype.

Closes #21364


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team April 14, 2023 18:33
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 14, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 14, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vinayak-kukreja
Copy link
Contributor Author

Exemption Request

I believe the unit test already cover the scenario that causes the error. If an env account id or region is not a string, now it should not be able to deploy so integ test would not make sense here. Let me know if that is not the case.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 14, 2023
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@corymhall corymhall added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Apr 17, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 17, 2023 12:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2a8a0d1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d9468c5 into main Apr 17, 2023
@mergify mergify bot deleted the vkukreja/type-check-accountid branch April 17, 2023 13:12
@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: Stack should validate that account is a string and not a number
3 participants