Skip to content

Conversation

@jk2l
Copy link
Contributor

@jk2l jk2l commented Jul 31, 2024

Issue #30967

Closes #30967

Reason for this change

Incorrect bundling required check for child stack return by the function

Description of changes

The current nested stack used parent stack's inherited function which cause incorrect assessment

More details description:

  • Given you have Stage "Stage", root stack "Stack1" and child stack "Stack1Nested". the this.node.path used is Stage/Stack1/StackNested, however the context it validate against is only "Stage/Stack1". the current function do not validate against child stack's stack name. To fix this, i simply have the child stack call the parent stack, and if the root stack is match then all child stack will be marked as bundling required.

Description of how you validated changes

Implemented via test driven approach, validate by test case

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jul 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 31, 2024 01:22
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@jk2l jk2l changed the title Fix(core): Fix asset bundling for nested stack with exclusive flag fix(core): Fix asset bundling for nested stack with exclusive flag Jul 31, 2024
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jul 31, 2024
@jk2l
Copy link
Contributor Author

jk2l commented Jul 31, 2024

Clarification Request: i have test case implemented, not sure what else is it asking here.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jul 31, 2024
@jk2l jk2l changed the title fix(core): Fix asset bundling for nested stack with exclusive flag fix(core): fix asset bundling for nested stack with exclusive flag Jul 31, 2024
@jk2l jk2l force-pushed the fix/asset-bundling branch from 09b05db to eb9417f Compare July 31, 2024 03:19
@jk2l
Copy link
Contributor Author

jk2l commented Jul 31, 2024

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 31, 2024
This was referenced Aug 1, 2024
@GavinZZ GavinZZ added the @aws-cdk/core Related to core CDK functionality label Jan 22, 2025
@otaviomacedo otaviomacedo self-assigned this Apr 16, 2025
@otaviomacedo otaviomacedo requested a review from a team as a code owner April 16, 2025 10:51
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 17, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 17, 2025
@shikha372 shikha372 added the skip-abstractions-board signal to automated workflow to skip adding to project board label Apr 22, 2025
@Abogical Abogical added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 18, 2025
@Abogical Abogical self-assigned this Jul 18, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 18, 2025 15:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Abogical
Copy link
Member

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Abogical
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

rebase

✅ Branch has been successfully rebased

@Abogical Abogical force-pushed the fix/asset-bundling branch from 5708957 to 97895d2 Compare July 18, 2025 15:40
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 97895d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 992b0a5 into aws:main Jul 18, 2025
10 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
@jk2l jk2l deleted the fix/asset-bundling branch August 19, 2025 01:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

@aws-cdk/core Related to core CDK functionality beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. skip-abstractions-board signal to automated workflow to skip adding to project board

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core: Asset bundling ignored when deploy with --exclusive flag with nested stack

6 participants