-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(core): fix asset bundling for nested stack with exclusive flag #30983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
Clarification Request: i have test case implemented, not sure what else is it asking here. |
|
Exemption Request |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
5708957 to
97895d2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue #30967
Closes #30967
Reason for this change
Incorrect bundling required check for child stack return by the function
Description of changes
The current nested stack used parent stack's inherited function which cause incorrect assessment
More details description:
this.node.pathused is Stage/Stack1/StackNested, however the context it validate against is only "Stage/Stack1". the current function do not validate against child stack's stack name. To fix this, i simply have the child stack call the parent stack, and if the root stack is match then all child stack will be marked as bundling required.Description of how you validated changes
Implemented via test driven approach, validate by test case
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license