Skip to content

Conversation

@Tietew
Copy link
Contributor

@Tietew Tietew commented Jun 17, 2025

Issue # (if applicable)

Closes #34737.

Reason for this change

Amazon Data Firehose supports to configure the time zone of timestamps in S3 object prefix.
For details, see https://docs.aws.amazon.com/firehose/latest/dev/s3-prefixes.html#timestamp-namespace

Description of changes

Added the timeZone prop to S3BucketProps interface to set ExtendedS3Destination.CustomTimeZone.
Note: Not in CommonProps since only ExtendedS3DestinationConfiguration supports time zone.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit test and integ test.
I've confirmed setting timeZone reflects to Firehose's console.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 17, 2025 09:25
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 17, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 17, 2025
Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve merge conflicts? PR is looking good

@ozelalisen ozelalisen self-assigned this Jul 14, 2025
@ozelalisen ozelalisen removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 14, 2025
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@mergify mergify bot dismissed ozelalisen’s stale review July 15, 2025 03:13

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1093c7c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2025
@Tietew
Copy link
Contributor Author

Tietew commented Jul 15, 2025

@ozelalisen
Thank for review!
I resolved conflicts.

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2bbe762 into aws:main Jul 15, 2025
22 of 23 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2025
@Tietew Tietew deleted the firehose-custom-timezone branch July 18, 2025 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(kinesisfirehose): support CustomTimeZone setting for S3 bucket destiation

3 participants