From 4adcc0d0c6c455c146320827dda97d5dcbd42b61 Mon Sep 17 00:00:00 2001 From: Niranjan Jayakar Date: Thu, 6 May 2021 14:22:18 +0100 Subject: [PATCH 1/2] fix(lambda-event-sources): incorrect documented defaults for stream types The defaults documented for `maxRecordAge` and `retryAttempts` properties for event sources that are 'stream' type were documented incorrectly. The implementation falls back to the defaults provided by CloudFormation. fixes #13908 --- packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts b/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts index c9de62653a93e..a2481513d18dd 100644 --- a/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts +++ b/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts @@ -41,7 +41,7 @@ export interface StreamEventSourceProps { * * Minimum value of 60 seconds * * Maximum value of 7 days * - * @default Duration.days(7) + * @default - the record is available for processing until it expires */ readonly maxRecordAge?: Duration; @@ -51,7 +51,7 @@ export interface StreamEventSourceProps { * * Minimum value of 0 * * Maximum value of 10000 * - * @default 10000 + * @default - retry until the record expires */ readonly retryAttempts?: number; From 7072fdc02b0c7208bd5e63e58f661571fe3ad10c Mon Sep 17 00:00:00 2001 From: Niranjan Jayakar Date: Tue, 11 May 2021 11:13:20 +0100 Subject: [PATCH 2/2] Update packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts --- packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts b/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts index a2481513d18dd..85b9728fafbc2 100644 --- a/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts +++ b/packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts @@ -41,7 +41,7 @@ export interface StreamEventSourceProps { * * Minimum value of 60 seconds * * Maximum value of 7 days * - * @default - the record is available for processing until it expires + * @default - the retention period configured on the stream */ readonly maxRecordAge?: Duration;