Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assertions): remove rosetta:extract from build command #17076

Merged
merged 1 commit into from
Oct 20, 2021
Merged

chore(assertions): remove rosetta:extract from build command #17076

merged 1 commit into from
Oct 20, 2021

Commits on Oct 20, 2021

  1. chore(assertions): remove rosetta:extract from build command (#17072)

    This form of executing Rosetta is not mocked by the jsii integ tests
    (which try executing a CDK build using a new version of the jsii tools).
    
    The jsii integ tests rely on passing environment variables `$CDK_BUILD_JSII`,
    `$PACMAK` and `$ROSETTA` (instead of replacing symlinks in the Node module farm).
    
    This leads to the generation of `.jsii.tabl.json` during build using the
    NPM-installed version of `jsii-rosetta`, which subsequently interferes with
    the run of `$PACMAK` which *is* the new version (since Rosetta tablets
    are supposed to be short-lived, there is no backwards compatibility guarantee
    between different versions).
    
    There will be a supported mechanism to achieve what this single post-build command is trying to achieve,
    so remove it.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    
    (cherry picked from commit ac54842)
    rix0rrr authored and Otavio Macedo committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    7a63b92 View commit details
    Browse the repository at this point in the history