From fc7f2806796aaf5ca7c6b1f7d29f4e3958aff11a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=F0=9F=91=A8=F0=9F=8F=BC=E2=80=8D=F0=9F=92=BB=20Romain=20M?= =?UTF-8?q?arcadier-Muller?= <rmuller@amazon.com> Date: Thu, 14 Feb 2019 15:22:18 +0100 Subject: [PATCH] fix: Npm ignores files and folders named "core" by default Since the release of `npm@6.8.0`, a version of `npm-packlist` is included that introduces a behavior to ignore anything named "core" by default. Added `!core` to the `.npmignore` file as a work around, and also more strictly pinned the `npm` version to auto-upgrade to so we don't get surprised in this kind of way anymore. Cause: npm/npm-packlist#24 --- install.sh | 2 +- packages/@aws-cdk/cdk/.npmignore | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/install.sh b/install.sh index b84099cd0fa3f..054ad67eee528 100755 --- a/install.sh +++ b/install.sh @@ -5,7 +5,7 @@ export NODE_OPTIONS="--max-old-space-size=4096 ${NODE_OPTIONS:-}" if ! npm ci --help; then echo "upgrading npm, because "npm ci" is not supported" - npm i -g npm + npm i -g npm@~6.8.0 fi echo "=============================================================================================" diff --git a/packages/@aws-cdk/cdk/.npmignore b/packages/@aws-cdk/cdk/.npmignore index b757d55c46996..5e482731ecbf0 100644 --- a/packages/@aws-cdk/cdk/.npmignore +++ b/packages/@aws-cdk/cdk/.npmignore @@ -13,4 +13,7 @@ dist # Include .jsii !.jsii -*.snk \ No newline at end of file +*.snk + +# Work around npm@6.8.0 ignoring 'core' by default -- https://github.com/npm/npm-packlist/issues/24 +!core