From 10c2b2bb3b7d6287210c146967a227219ef20ccd Mon Sep 17 00:00:00 2001 From: Sumu Date: Tue, 14 Nov 2023 09:52:38 -0500 Subject: [PATCH 01/15] initial commit Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index d4d142e830c02..b977c0cac8a5b 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -46,6 +46,8 @@ This module supports features under [API Gateway v2](https://docs.aws.amazon.com that lets users set up Websocket and HTTP APIs. REST APIs can be created using the `aws-cdk-lib/aws-apigateway` module. +Websocket and HTTP APIs use the same Cloudformation resources under the hood. However, this module separates them into two separate constructs since there are a number of different properties + ## HTTP API HTTP APIs enable creation of RESTful APIs that integrate with AWS Lambda functions, known as Lambda proxy integration, From 7ff49dbc80aa402a3b3c3414a36aec0159259549 Mon Sep 17 00:00:00 2001 From: Sumu Date: Tue, 14 Nov 2023 13:48:47 -0500 Subject: [PATCH 02/15] add comment on decision to split http/websocket apis Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index b977c0cac8a5b..c242a5c525ebb 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -46,7 +46,7 @@ This module supports features under [API Gateway v2](https://docs.aws.amazon.com that lets users set up Websocket and HTTP APIs. REST APIs can be created using the `aws-cdk-lib/aws-apigateway` module. -Websocket and HTTP APIs use the same Cloudformation resources under the hood. However, this module separates them into two separate constructs since there are a number of different properties +HTTP and Websocket APIs use the same Cloudformation resources under the hood. However, this module separates them into two separate constructs for a more efficient abstraction since there are a number of Cloudformation properties that specifically apply only to one or the other type of API. ## HTTP API From e5655496b00148d39b11be6c27d3799c898845e1 Mon Sep 17 00:00:00 2001 From: Sumu Date: Tue, 14 Nov 2023 13:50:15 -0500 Subject: [PATCH 03/15] typo Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index c242a5c525ebb..5c9a377ac481c 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -46,7 +46,7 @@ This module supports features under [API Gateway v2](https://docs.aws.amazon.com that lets users set up Websocket and HTTP APIs. REST APIs can be created using the `aws-cdk-lib/aws-apigateway` module. -HTTP and Websocket APIs use the same Cloudformation resources under the hood. However, this module separates them into two separate constructs for a more efficient abstraction since there are a number of Cloudformation properties that specifically apply only to one or the other type of API. +HTTP and Websocket APIs use the same Cloudformation resources under the hood. However, this module separates them into two separate constructs for a more efficient abstraction since there are a number of Cloudformation properties that specifically apply only to each type of API. ## HTTP API From 6647cff7dbd56bfd877a646e8b40e144b188a10e Mon Sep 17 00:00:00 2001 From: Sumu Date: Tue, 14 Nov 2023 17:41:05 -0500 Subject: [PATCH 04/15] fix confusing bookstore default example Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index 5c9a377ac481c..6e3672f2a12e9 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -67,16 +67,15 @@ integration, HTTP proxy integration and, AWS service integrations, also known as [Configuring integrations](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations.html). Integrations are available at the `aws-apigatewayv2-integrations` module and more information is available in that module. -As an early example, the following code snippet configures a route `GET /books` with an HTTP proxy integration all -configures all other HTTP method calls to `/books` to a lambda proxy. +As an early example, we have a website for a bookstore where the following code snippet configures a route `GET /books` with an HTTP proxy integration. All other HTTP method calls to `/books` route to a default lambda proxy for the bookstore. ```ts import { HttpUrlIntegration, HttpLambdaIntegration } from '@aws-cdk/aws-apigatewayv2-integrations-alpha'; const getBooksIntegration = new HttpUrlIntegration('GetBooksIntegration', 'https://get-books-proxy.example.com'); -declare const booksDefaultFn: lambda.Function; -const booksDefaultIntegration = new HttpLambdaIntegration('BooksIntegration', booksDefaultFn); +declare const bookStoreDefaultFn: lambda.Function; +const bookStoreDefaultIntegration = new HttpLambdaIntegration('BooksIntegration', bookStoreDefaultFn); const httpApi = new apigwv2.HttpApi(this, 'HttpApi'); @@ -88,7 +87,7 @@ httpApi.addRoutes({ httpApi.addRoutes({ path: '/books', methods: [ apigwv2.HttpMethod.ANY ], - integration: booksDefaultIntegration, + integration: bookStoreDefaultIntegration, }); ``` From ab01755323a59afb44e33bcc0724bd9d3555e3cf Mon Sep 17 00:00:00 2001 From: Sumu Date: Tue, 14 Nov 2023 17:43:45 -0500 Subject: [PATCH 05/15] typos in auth readme Signed-off-by: Sumu --- .../@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md index b893c5aed9107..dbf6680af4d9e 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md @@ -39,9 +39,9 @@ API](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-acces ## HTTP APIs -Access control for Http Apis is managed by restricting which routes can be invoked via. +Access control for Http APIs is managed by restricting which routes can be invoked via. -Authorizers and scopes can either be applied to the api, or specifically for each route. +Authorizers and scopes can either be applied to the API, or specifically for each route. ### Default Authorization @@ -150,7 +150,7 @@ api.addRoutes({ #### User Pool Authorizer -User Pool Authorizer is a type of JWT Authorizer that uses a Cognito user pool and app client to control who can access your Api. After a successful authorization from the app client, the generated access token will be used as the JWT. +User Pool Authorizer is a type of JWT Authorizer that uses a Cognito user pool and app client to control who can access your API. After a successful authorization from the app client, the generated access token will be used as the JWT. Clients accessing an API that uses a user pool authorizer must first sign in to a user pool and obtain an identity or access token. They must then use this token in the specified `identitySource` for the API call. More information is available at [using Amazon Cognito user From c5b2a4b4bff5e1f12122e9d7ffc8af3f0bafa263 Mon Sep 17 00:00:00 2001 From: Sumu Date: Wed, 15 Nov 2023 11:08:24 -0500 Subject: [PATCH 06/15] add extra line to integrations readme Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md index 340a2d54af6e9..05bacb7e89c51 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md @@ -225,3 +225,4 @@ webSocketApi.addRoute('sendmessage', { integration: new WebSocketLambdaIntegration('SendMessageIntegration', messageHandler), }); ``` +Extra line so this shows up in the files changes for the API Review - delete later \ No newline at end of file From 4042a33a952deb54f232035f8460d192ce80e831 Mon Sep 17 00:00:00 2001 From: Chris Garvis Date: Thu, 16 Nov 2023 09:48:31 -0500 Subject: [PATCH 07/15] doc: fix casing for CloudFormation --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index 6e3672f2a12e9..c655944216a4d 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -46,7 +46,7 @@ This module supports features under [API Gateway v2](https://docs.aws.amazon.com that lets users set up Websocket and HTTP APIs. REST APIs can be created using the `aws-cdk-lib/aws-apigateway` module. -HTTP and Websocket APIs use the same Cloudformation resources under the hood. However, this module separates them into two separate constructs for a more efficient abstraction since there are a number of Cloudformation properties that specifically apply only to each type of API. +HTTP and Websocket APIs use the same CloudFormation resources under the hood. However, this module separates them into two separate constructs for a more efficient abstraction since there are a number of CloudFormation properties that specifically apply only to each type of API. ## HTTP API From 0d96424ef4909593ed40f16317a387696e44143d Mon Sep 17 00:00:00 2001 From: Sumu Date: Fri, 17 Nov 2023 17:21:55 -0500 Subject: [PATCH 08/15] Add Mike feedback Signed-off-by: Sumu --- .../aws-apigatewayv2-authorizers-alpha/README.md | 12 ++++++------ .../aws-apigatewayv2-integrations-alpha/README.md | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md index dbf6680af4d9e..47ccaf50d0f68 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md @@ -33,19 +33,19 @@ ## Introduction API Gateway supports multiple mechanisms for controlling and managing access to your HTTP API. They are mainly -classified into Lambda Authorizers, JWT authorizers and standard AWS IAM roles and policies. More information is +classified into Lambda Authorizers, JWT authorizers, and standard AWS IAM roles and policies. More information is available at [Controlling and managing access to an HTTP API](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-access-control.html). ## HTTP APIs -Access control for Http APIs is managed by restricting which routes can be invoked via. +Access control for HTTP APIs is managed by restricting which routes can be invoked via. Authorizers and scopes can either be applied to the API, or specifically for each route. ### Default Authorization -When using default authorization, all routes of the api will inherit the configuration. +When using default authorization, all routes of the API will inherit the configuration. In the example below, all routes will require the `manage:books` scope present in order to invoke the integration. @@ -65,12 +65,12 @@ const api = new apigwv2.HttpApi(this, 'HttpApi', { ### Route Authorization -Authorization can also configured for each Route. When a route authorization is configured, it takes precedence over default authorization. +Authorization can also be configured for each Route. When a route authorization is configured, it takes precedence over default authorization. The example below showcases default authorization, along with route authorization. It also shows how to remove authorization entirely for a route. - `GET /books` and `GET /books/{id}` use the default authorizer settings on the api -- `POST /books` will require the [write:books] scope +- `POST /books` will require the ['write:books'] scope - `POST /login` removes the default authorizer (unauthenticated route) ```ts @@ -120,7 +120,7 @@ JWT authorizers allow the use of JSON Web Tokens (JWTs) as part of [OpenID Conne When configured, API Gateway validates the JWT submitted by the client, and allows or denies access based on its content. -The location of the token is defined by the `identitySource` which defaults to the http `Authorization` header. However it also +The location of the token is defined by the `identitySource` which defaults to the HTTP `Authorization` header. However it also [supports a number of other options](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-lambda-authorizer.html#http-api-lambda-authorizer.identity-sources). It then decodes the JWT and validates the signature and claims, against the options defined in the authorizer and route (scopes). For more information check the [JWT Authorizer documentation](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-jwt-authorizer.html). diff --git a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md index 05bacb7e89c51..ca089e228bbad 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md @@ -35,7 +35,7 @@ Lambda integrations enable integrating an HTTP API route with a Lambda function. API Gateway service forwards the request to the Lambda function and returns the function's response to the client. The API Gateway service will invoke the lambda function with an event payload of a specific format. The service expects -the function to respond in a specific format. The details on this format is available at [Working with AWS Lambda +the function to respond in a specific format. The details on this format are available at [Working with AWS Lambda proxy integrations](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html). The following code configures a route `GET /books` with a Lambda proxy integration. @@ -204,11 +204,11 @@ WebSocket integrations connect a route to backend resources. The following integ ### Lambda WebSocket Integration Lambda integrations enable integrating a WebSocket API route with a Lambda function. When a client connects/disconnects -or sends message specific to a route, the API Gateway service forwards the request to the Lambda function +or sends a message specific to a route, the API Gateway service forwards the request to the Lambda function The API Gateway service will invoke the lambda function with an event payload of a specific format. -The following code configures a `sendmessage` route with a Lambda integration +The following code configures a `sendMessage` route with a Lambda integration ```ts import { WebSocketLambdaIntegration } from '@aws-cdk/aws-apigatewayv2-integrations-alpha'; @@ -221,7 +221,7 @@ new apigwv2.WebSocketStage(this, 'mystage', { }); declare const messageHandler: lambda.Function; -webSocketApi.addRoute('sendmessage', { +webSocketApi.addRoute('sendMessage', { integration: new WebSocketLambdaIntegration('SendMessageIntegration', messageHandler), }); ``` From 88adae84546efe9592bf74ac1803903018528243 Mon Sep 17 00:00:00 2001 From: Sumu Date: Fri, 17 Nov 2023 17:23:22 -0500 Subject: [PATCH 09/15] Fix Lambda casing Signed-off-by: Sumu --- .../@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md index ca089e228bbad..b09fd012db4a9 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md @@ -34,7 +34,7 @@ Integrations connect a route to backend resources. HTTP APIs support Lambda prox Lambda integrations enable integrating an HTTP API route with a Lambda function. When a client invokes the route, the API Gateway service forwards the request to the Lambda function and returns the function's response to the client. -The API Gateway service will invoke the lambda function with an event payload of a specific format. The service expects +The API Gateway service will invoke the Lambda function with an event payload of a specific format. The service expects the function to respond in a specific format. The details on this format are available at [Working with AWS Lambda proxy integrations](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html). @@ -206,7 +206,7 @@ WebSocket integrations connect a route to backend resources. The following integ Lambda integrations enable integrating a WebSocket API route with a Lambda function. When a client connects/disconnects or sends a message specific to a route, the API Gateway service forwards the request to the Lambda function -The API Gateway service will invoke the lambda function with an event payload of a specific format. +The API Gateway service will invoke the Lambda function with an event payload of a specific format. The following code configures a `sendMessage` route with a Lambda integration From f28fd8c13a2e08424ffa8a825874030a30971b2d Mon Sep 17 00:00:00 2001 From: Sumu Date: Mon, 20 Nov 2023 10:55:57 -0500 Subject: [PATCH 10/15] add VPC Link code Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index c655944216a4d..9b4ebe14ed8cc 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -311,9 +311,15 @@ The following code creates a `VpcLink` to a private VPC. ```ts import * as ec2 from 'aws-cdk-lib/aws-ec2'; +import * as elb from 'aws-cdk-lib/aws-elasticloadbalancingv2'; const vpc = new ec2.Vpc(this, 'VPC'); +const alb = new elb.ApplicationLoadBalancer(stack, 'AppLoadBalancer', { vpc }); + const vpcLink = new apigwv2.VpcLink(this, 'VpcLink', { vpc }); + +// Creating an HTTP ALB Integration: +const albIntegration = new integrations.HttpAlbIntegration('ALBIntegration', alb.listeners[0], {}); ``` Any existing `VpcLink` resource can be imported into the CDK app via the `VpcLink.fromVpcLinkAttributes()`. From 108effd9f90c7a11c550e615864e3cb879c3b2c4 Mon Sep 17 00:00:00 2001 From: Sumu Date: Mon, 20 Nov 2023 11:14:53 -0500 Subject: [PATCH 11/15] remove extra line at the end Signed-off-by: Sumu --- .../@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md index b09fd012db4a9..b6cde88c354dd 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md @@ -224,5 +224,4 @@ declare const messageHandler: lambda.Function; webSocketApi.addRoute('sendMessage', { integration: new WebSocketLambdaIntegration('SendMessageIntegration', messageHandler), }); -``` -Extra line so this shows up in the files changes for the API Review - delete later \ No newline at end of file +``` \ No newline at end of file From 65f9ba42bf31d3c476c7fe094fc5eb984a9a158a Mon Sep 17 00:00:00 2001 From: Sumu Date: Mon, 20 Nov 2023 12:04:59 -0500 Subject: [PATCH 12/15] add newline at end of file back Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md index b6cde88c354dd..f041689741cbf 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/README.md @@ -224,4 +224,4 @@ declare const messageHandler: lambda.Function; webSocketApi.addRoute('sendMessage', { integration: new WebSocketLambdaIntegration('SendMessageIntegration', messageHandler), }); -``` \ No newline at end of file +``` From 991386f2f439351b514b7f8f40674411b062177b Mon Sep 17 00:00:00 2001 From: Sumu Date: Mon, 20 Nov 2023 13:42:14 -0500 Subject: [PATCH 13/15] add import statement Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index 9b4ebe14ed8cc..0ab44b9743236 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -312,6 +312,7 @@ The following code creates a `VpcLink` to a private VPC. ```ts import * as ec2 from 'aws-cdk-lib/aws-ec2'; import * as elb from 'aws-cdk-lib/aws-elasticloadbalancingv2'; +import { HttpAlbIntegration } from '@aws-cdk/aws-apigatewayv2-integrations-alpha'; const vpc = new ec2.Vpc(this, 'VPC'); const alb = new elb.ApplicationLoadBalancer(stack, 'AppLoadBalancer', { vpc }); @@ -319,7 +320,7 @@ const alb = new elb.ApplicationLoadBalancer(stack, 'AppLoadBalancer', { vpc }); const vpcLink = new apigwv2.VpcLink(this, 'VpcLink', { vpc }); // Creating an HTTP ALB Integration: -const albIntegration = new integrations.HttpAlbIntegration('ALBIntegration', alb.listeners[0], {}); +const albIntegration = new HttpAlbIntegration('ALBIntegration', alb.listeners[0], {}); ``` Any existing `VpcLink` resource can be imported into the CDK app via the `VpcLink.fromVpcLinkAttributes()`. From 76b3aca118d7fba8eae64dbfdc4146989d06b260 Mon Sep 17 00:00:00 2001 From: Sumu Date: Mon, 20 Nov 2023 14:10:49 -0500 Subject: [PATCH 14/15] typo in vpc code Signed-off-by: Sumu --- packages/@aws-cdk/aws-apigatewayv2-alpha/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md index 0ab44b9743236..5c06e47869076 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-alpha/README.md @@ -315,7 +315,7 @@ import * as elb from 'aws-cdk-lib/aws-elasticloadbalancingv2'; import { HttpAlbIntegration } from '@aws-cdk/aws-apigatewayv2-integrations-alpha'; const vpc = new ec2.Vpc(this, 'VPC'); -const alb = new elb.ApplicationLoadBalancer(stack, 'AppLoadBalancer', { vpc }); +const alb = new elb.ApplicationLoadBalancer(this, 'AppLoadBalancer', { vpc }); const vpcLink = new apigwv2.VpcLink(this, 'VpcLink', { vpc }); From f5fd9e017f4739df1cf7339be289586334a53beb Mon Sep 17 00:00:00 2001 From: Sumu Pitchayan <35242245+sumupitchayan@users.noreply.github.com> Date: Tue, 21 Nov 2023 09:23:58 -0500 Subject: [PATCH 15/15] Update packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com> --- packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md b/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md index 47ccaf50d0f68..0f37f4059086f 100644 --- a/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md +++ b/packages/@aws-cdk/aws-apigatewayv2-authorizers-alpha/README.md @@ -70,7 +70,7 @@ Authorization can also be configured for each Route. When a route authorization The example below showcases default authorization, along with route authorization. It also shows how to remove authorization entirely for a route. - `GET /books` and `GET /books/{id}` use the default authorizer settings on the api -- `POST /books` will require the ['write:books'] scope +- `POST /books` will require the `['write:books']` scope - `POST /login` removes the default authorizer (unauthenticated route) ```ts