Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): support secret environment variables #2994

Merged
merged 30 commits into from
Jul 29, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
146f13e
feat(ecs): support secret environment variables
jogold Jun 21, 2019
5384d55
Merge branch 'master' into ecs-secrets
jogold Jun 21, 2019
bf91871
Merge branch 'master' into ecs-secrets
jogold Jun 21, 2019
a0bb714
add IAM permissions
jogold Jun 24, 2019
2a5155b
Merge branch 'master' into ecs-secrets
jogold Jun 24, 2019
d697273
disable-awslint:ref-via-interface
jogold Jun 24, 2019
d1c31bf
Merge branch 'master' into ecs-secrets
jogold Jun 26, 2019
3c75145
Merge branch 'master' into ecs-secrets
Jul 1, 2019
a242dca
Merge branch 'master' into ecs-secrets
jogold Jul 3, 2019
67b0abe
Merge branch 'ecs-secrets' of github.com:jogold/aws-cdk into ecs-secrets
jogold Jul 3, 2019
f8d0efc
scheduled task
jogold Jul 3, 2019
f3cb37a
typo
jogold Jul 4, 2019
39909d7
typo
jogold Jul 4, 2019
43f8244
typo
jogold Jul 4, 2019
3a6a374
Merge branch 'master' into ecs-secrets
jogold Jul 22, 2019
f300b28
secrets and non breaking
jogold Jul 22, 2019
bcc350a
JSDoc
jogold Jul 22, 2019
17e0964
non breaking renderContainerDefinition
jogold Jul 22, 2019
d629929
renderKV
jogold Jul 22, 2019
80d4495
base props
jogold Jul 22, 2019
199de19
polymorphism
jogold Jul 22, 2019
037f9e4
base props
jogold Jul 22, 2019
6cca252
JSDoc for queue env vars
jogold Jul 23, 2019
aedbbb8
make base props internal
jogold Jul 23, 2019
410cfd5
remove note about scheduled fargate tasks
jogold Jul 23, 2019
5f5cf12
update README
jogold Jul 23, 2019
6298b4d
Merge branch 'master' into ecs-secrets
Jul 23, 2019
865d7f2
revert base props
jogold Jul 23, 2019
a2032a6
Merge branch 'ecs-secrets' of github.com:jogold/aws-cdk into ecs-secrets
jogold Jul 23, 2019
f27f8c5
Merge branch 'master' into ecs-secrets
jogold Jul 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ export interface LoadBalancedServiceBaseProps extends BaseProps {
*/
readonly certificate?: ICertificate;

/**
* Environment variables to pass to the container
*
* @default - No environment variables.
*/
readonly environment?: { [key: string]: string };

/**
* Whether to create an AWS log driver
*
Expand Down
7 changes: 0 additions & 7 deletions packages/@aws-cdk/aws-ecs-patterns/lib/base/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@ export interface BaseProps {
*/
readonly image: ecs.ContainerImage;

/**
* The environment variables to pass to the container.
*
* @default 'QUEUE_NAME: queue.queueName'
*/
readonly environment?: { [key: string]: string };

/**
* Secret environment variables to pass to the container
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ export interface QueueProcessingServiceBaseProps extends BaseProps {
*/
readonly enableLogging?: boolean;

/**
* The environment variables to pass to the container.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the default or will it always be passed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not mine, it seems that it's always passed, I can update the doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that would be nice

* @default 'QUEUE_NAME: queue.queueName'
*/
readonly environment?: { [key: string]: string };

/**
* A queue for which to process items from.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ export interface ScheduledTaskBaseProps extends BaseProps {
* @default 1
*/
readonly desiredTaskCount?: number;

/**
* The environment variables to pass to the container.
*
* @default none
*/
readonly environment?: { [key: string]: string };
}

/**
Expand Down