From 86bce40f322250e318ce713f0102210e3e642b65 Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Tue, 29 Oct 2024 16:50:48 +0000 Subject: [PATCH 1/2] chore(aws-cdk): increase coverage limits --- packages/aws-cdk/jest.config.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/aws-cdk/jest.config.js b/packages/aws-cdk/jest.config.js index ae3fb7ad49a8d..b9ff82cb2587a 100644 --- a/packages/aws-cdk/jest.config.js +++ b/packages/aws-cdk/jest.config.js @@ -3,8 +3,10 @@ module.exports = { ...baseConfig, coverageThreshold: { global: { - statements: 60, - branches: 45, + statements: 81, + branches: 68, + functions: 84, + lines: 81 }, }, From 2a78c1b082e7bc8b213ba3d5a78bdf6898caffb4 Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Tue, 29 Oct 2024 16:53:58 +0000 Subject: [PATCH 2/2] add a warning --- packages/aws-cdk/jest.config.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/aws-cdk/jest.config.js b/packages/aws-cdk/jest.config.js index b9ff82cb2587a..32c020fda522b 100644 --- a/packages/aws-cdk/jest.config.js +++ b/packages/aws-cdk/jest.config.js @@ -3,6 +3,9 @@ module.exports = { ...baseConfig, coverageThreshold: { global: { + // We want to improve our test coverage + // DO NOT LOWER THESE VALUES! + // If you need to break glass, open an issue to re-up the values with additional test coverage statements: 81, branches: 68, functions: 84,