-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: upgrade @aws-cdk/integ-runner to 2.186.5 #34385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depend on external factors
e16c5d1 to
60362b8
Compare
106434c to
f3b1c1c
Compare
1 task
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shikha372
approved these changes
May 8, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
The integ tests changed in this PR are failing the yarn upgrade job: #34378
This is because recommended value of the
createNewPoliciesWithAddToRolePolicyfeature flag changed in theinteg-runnerpackage:aws/aws-cdk-cli@4bd6149#diff-cc2aa6328f725cd5a81d9ded74633857d38594c65a715e3411b80ec52ca5cdacR68
So making this PR specifically for upgrading
@aws-cdk/integ-runnerand updating the snapshots required by it.Description of changes
Upgraded
@aws-cdk/integ-runner, then updated the snapshotsDescription of how you validated changes
There is no actual code change to CDK constructs.
Checked the snapshots and see expected changes resulted from feature flag value being changed.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license