Skip to content

Conversation

@samson-keung
Copy link
Contributor

@samson-keung samson-keung commented May 7, 2025

Issue # (if applicable)

N/A

Reason for this change

The integ tests changed in this PR are failing the yarn upgrade job: #34378

This is because recommended value of the createNewPoliciesWithAddToRolePolicy feature flag changed in the integ-runner package:

aws/aws-cdk-cli@4bd6149#diff-cc2aa6328f725cd5a81d9ded74633857d38594c65a715e3411b80ec52ca5cdacR68

So making this PR specifically for upgrading @aws-cdk/integ-runner and updating the snapshots required by it.

Description of changes

Upgraded @aws-cdk/integ-runner, then updated the snapshots

Description of how you validated changes

There is no actual code change to CDK constructs.

Checked the snapshots and see expected changes resulted from feature flag value being changed.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@samson-keung samson-keung changed the title chore: set createNewPoliciesWithAddToRolePolicy ff explicitly chore: set createNewPoliciesWithAddToRolePolicy ff explicitly in integ tests May 7, 2025
@github-actions github-actions bot added the p2 label May 7, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 7, 2025 20:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 7, 2025
@samson-keung samson-keung changed the title chore: set createNewPoliciesWithAddToRolePolicy ff explicitly in integ tests chore: upgrade @aws-cdk/integ-runner to 2.186.5 May 8, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 989cf68
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 8, 2025
@mergify
Copy link
Contributor

mergify bot commented May 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0049729 into aws:main May 8, 2025
18 of 20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants