Skip to content

Conversation

@phuhung273
Copy link
Contributor

Issue # (if applicable)

None

Reason for this change

https://aws.amazon.com/about-aws/whats-new/2025/04/amazon-ec2-i7i-high-performance-storage-optimized-instances/

Description of changes

EC2 add i7i instance class

Description of how you validated changes

$ aws ec2 describe-instance-types | grep -e i7i
            "InstanceType": "i7ie.18xlarge",
            "InstanceType": "i7ie.24xlarge",
            "InstanceType": "i7i.12xlarge",
            "InstanceType": "i7i.2xlarge",

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 13, 2025 22:56
@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels May 13, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 13, 2025
samson-keung
samson-keung previously approved these changes May 15, 2025
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mergify
Copy link
Contributor

mergify bot commented May 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 15, 2025
@mergify
Copy link
Contributor

mergify bot commented May 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 15, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed samson-keung’s stale review May 15, 2025 18:31

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 15, 2025
@phuhung273 phuhung273 requested a review from samson-keung May 17, 2025 02:21
@phuhung273
Copy link
Contributor Author

phuhung273 commented May 19, 2025

Hi @samson-keung, can you help reapprove. It is stuck somehow. Thank you.

Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@mergify
Copy link
Contributor

mergify bot commented May 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@phuhung273
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@phuhung273
Copy link
Contributor Author

The CodeBuild pipeline is stuck! Blocking PRs from merging

@samson-keung
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

update

☑️ Nothing to do, the required conditions are not met

  • #commits-behind > 0 [📌 update requirement]
  • queue-position = -1 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34453 has been dequeued, merge conditions unmatch:

  • -closed
  • status-success~=AWS CodeBuild us-east-1
  • any of [🛡 GitHub branch protection]:
    • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash|priority-pr)
  • -merged
  • -title~=(WIP|wip)
  • base!=release
  • status-success=validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = validate-pr
    • check-neutral = validate-pr
    • check-skipped = validate-pr

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2025
@samson-keung
Copy link
Contributor

This is strange. First time seeing this. Will try to fix this today

@samson-keung samson-keung reopened this May 21, 2025
@samson-keung samson-keung self-requested a review May 21, 2025 17:27
samson-keung
samson-keung previously approved these changes May 21, 2025
@mergify mergify bot dismissed stale reviews from vishaalmehrishi and samson-keung May 21, 2025 17:31

Pull request has been modified.

@samson-keung samson-keung changed the title chore(ec2): add i7i instance class feat(ec2): add i7i instance class May 21, 2025
@samson-keung samson-keung added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label May 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@samson-keung samson-keung added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels May 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 21, 2025 17:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 21, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e03837b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3fe8ab4 into aws:main May 21, 2025
16 checks passed
@phuhung273 phuhung273 deleted the ec2-instance-type branch May 21, 2025 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants