Skip to content

Conversation

@vivian12300
Copy link
Contributor

Issue # (if applicable)

N/A

Reason for this change

Add new field to feature flag report for the cdk flags CLI tool.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 29, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 29, 2025 19:54
@github-actions github-actions bot added the p2 label Jul 29, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 29, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@vivian12300 vivian12300 marked this pull request as ready for review July 30, 2025 12:48
@vivian12300 vivian12300 requested a review from a team as a code owner July 30, 2025 12:48
"@aws-cdk/asset-awscli-v1": "2.2.242",
"@aws-cdk/asset-node-proxy-agent-v6": "^2.1.0",
"@aws-cdk/cloud-assembly-schema": "^45.2.0",
"@aws-cdk/cloud-assembly-schema": "^48.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this upgrade intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I need the newest version of the cloud assembly schema because I updated it to have the unconfiguredBehavesLike property I'm adding here.

"devDependencies": {
"@aws-cdk/cdk-build-tools": "0.0.0",
"@aws-cdk/cloud-assembly-schema": "^45.2.0",
"@aws-cdk/cloud-assembly-schema": "^48.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as below, is this upgrade intentional? Seems like it may not be in scope of this PR.

@vivian12300 vivian12300 added the pr-linter/exempt-readme The PR linter will not require README changes label Aug 1, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 1, 2025 13:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3e196ff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 1, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8bff8f9 into aws:main Aug 1, 2025
31 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants