-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: add new field to feature flag report #35108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
| "@aws-cdk/asset-awscli-v1": "2.2.242", | ||
| "@aws-cdk/asset-node-proxy-agent-v6": "^2.1.0", | ||
| "@aws-cdk/cloud-assembly-schema": "^45.2.0", | ||
| "@aws-cdk/cloud-assembly-schema": "^48.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this upgrade intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I need the newest version of the cloud assembly schema because I updated it to have the unconfiguredBehavesLike property I'm adding here.
| "devDependencies": { | ||
| "@aws-cdk/cdk-build-tools": "0.0.0", | ||
| "@aws-cdk/cloud-assembly-schema": "^45.2.0", | ||
| "@aws-cdk/cloud-assembly-schema": "^48.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as below, is this upgrade intentional? Seems like it may not be in scope of this PR.
…n12300/aws-cdk into change-feature-flag-report
…n12300/aws-cdk into change-feature-flag-report
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
Add new field to feature flag report for the
cdk flagsCLI tool.Describe any new or updated permissions being added
N/A
Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license