-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(eks): support MixedInstancePolicy for self-managed nodes #35923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chancepants
wants to merge
14
commits into
aws:main
Choose a base branch
from
chancepants:mixed-instances
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an optional parameter to the cluster addAutoScalingGroupCapacity method to support MixedInstancePolicy. Currently the only alternative is to heavily utilize escape hatches to attach a MixedInstancePolicy to the ASG created within this method.
This was referenced Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional parameter to the cluster addAutoScalingGroupCapacity method to support MixedInstancePolicy. Currently the only alternative is to heavily utilize escape hatches to attach a MixedInstancePolicy to the ASG created within this method.
Issue # (if applicable)
Closes #35732
Reason for this change
Users of eks
cluster.addAutoScalingGroupCapcitydo not have a convenient way to apply a MixedInstancePolicy to their ASG.Description of changes
Added an optional parameter to
cluster.addAutoScalingGroupCapcityto allow users to provide a MixedInstancePolicy which is applied to the ASG.Description of how you validated changes
I added unit tests which largely cover the validation logic and added a unittest to verify CDK deployments succeed with the new parameter.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license