Skip to content

Conversation

@badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Relates #32569

Reason for this change

Throw typed errors everywhere.

Description of changes

  • add typed error for neptune alpha module

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 5, 2025 15:00
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 5, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@badmintoncryer badmintoncryer changed the title use typed error chore(neptune): use typed error Nov 5, 2025
@aws-cdk-automation aws-cdk-automation dismissed stale reviews from themself November 5, 2025 15:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer changed the title chore(neptune): use typed error chore(neptune): use typed erro Nov 5, 2025
@badmintoncryer badmintoncryer changed the title chore(neptune): use typed erro chore(neptune): use typed error Nov 5, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 6, 2025
@ozelalisen ozelalisen changed the title chore(neptune): use typed error chore(neptune-alpha): use typed error Nov 6, 2025
@ozelalisen ozelalisen self-assigned this Nov 6, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 6, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 832eed8 into aws:main Nov 6, 2025
18 of 19 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2025
@badmintoncryer badmintoncryer deleted the typed-error branch November 6, 2025 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants