chore(spec2cdk): refactor for mixins #35999
Conversation
mrgrain
force-pushed
the
mrgrain/chore/refactor-spec2cdk
branch
from
50d58bd to
e7f032b
Compare
| { | ||
| type: ComponentType.CUSTOM_RESOURCE_PROVIDER, | ||
| sourceCode: path.resolve(__dirname, '..', 'core', 'cross-region-ssm-writer-handler', 'index.ts'), | ||
| constructorVisibility: MemberVisibility.Public, |
There was a problem hiding this comment.
This is changing because the generated class is extended by another class. Previously due to a bug in @cdklabs/typewriter, the generated classes ended up with a public constructor instead of a private one as intended. After the dependency update this failed for the one case, which we make public again to satisfy the compiler.
mrgrain
force-pushed
the
mrgrain/chore/refactor-spec2cdk
branch
2 times, most recently
from
67057b3 to
7a12a34
Compare
mrgrain
force-pushed
the
mrgrain/chore/refactor-spec2cdk
branch
from
7a12a34 to
6e4b611
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
Reason for this change
Refactoring some spec2cdk code to make it more re-usable for mixins codegen.
Description of changes
jsiiand@cdklabs/typewriterto the latest versions@aws-cdk/custom-resource-handlersthat arouse after the typewriter update. It's a private package and the changed generated code is also private, so this is safe.spec2cdkcode to make it more reusable.Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing tests passing. Additionally compared generated code by hand.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license