chore(spec2cdk): refactor code generation with LibraryBuilder abstraction #36081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/chore/spec2cdk-li-builder
branch
4 times, most recently
from
5d0c245 to
414234a
Compare
mrgrain
commented
Nov 17, 2025
| * Output debug messages | ||
| * @default false | ||
| */ | ||
| readonly augmentationsSupport?: boolean; |
Contributor
Author
There was a problem hiding this comment.
This was an unused option that silently got ignored. Instead augmentations were always enabled.
…tion Introduces a new LibraryBuilder base class to abstract the code generation process for CDK libraries. This refactoring separates concerns between the general library building logic and aws-cdk-lib-specific implementation. Key changes: - Create LibraryBuilder base class with generic service submodule support - Extract AwsCdkLibBuilder as a specialized implementation - Introduce ServiceSubmodule abstraction for better modularity - Move selective imports logic to service-submodule - Update TypeConverter to support partial type definitions for mixins - Adjust import paths and file patterns configuration
mrgrain
force-pushed
the
mrgrain/chore/spec2cdk-li-builder
branch
from
0d5b24a to
50d3abe
Compare
rix0rrr
approved these changes
Nov 17, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
The current spec2cdk code generator (AstBuilder) is tightly coupled to aws-cdk-lib's specific structure, making it difficult to generate code for other targets like preview packages. We need a more flexible architecture that can support different library structures while maintaining the existing aws-cdk-lib generation.
Description of changes
This PR refactors the code generation architecture to separate concerns between generic library building and aws-cdk-lib-specific implementation:
Why LibraryBuilder base class?
Why ServiceSubmodule abstraction?
Key changes:
Describe any new or updated permissions being added
None.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license