Skip to content

Conversation

@ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Nov 22, 2025

Reason for this change

Adds vended logs delivery for supported resources to various destinations:

import '@aws-cdk/mixins-preview/with';
import * as cloudfrontMixins from '@aws-cdk/mixins-preview/aws_cloudfront/mixins';

// Create CloudFront distribution
declare const bucket: s3.Bucket;
const distribution = new cloudfront.Distribution(scope, 'Distribution', {
  defaultBehavior: {
    origin: origins.S3BucketOrigin.withOriginAccessControl(bucket),
  },
});

// Create log destination
const logGroup = new logs.LogGroup(scope, 'DeliveryLogGroup');

// Configure log delivery using the mixin
distribution
  .with(cloudfrontMixins.CfnDistributionLogsMixin.CONNECTION_LOGS.toLogGroup(logGroup));

Description of changes

Adds codegen for VendedLogs Mixins classes.
Creates a VendedLogs Mixin class for each resource that supports vended logs and creates helper classes for each log type a resource supports.

Description of how you validated changes

snapshot and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 22, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 22, 2025 22:30
@github-actions github-actions bot added the p2 label Nov 22, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 22, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Nov 22, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Nov 24, 2025
@ShadowCat567 ShadowCat567 changed the title [WIP]chore(mixins-preview): codegen for vended logs mixins chore(mixins-preview): codegen for vended logs mixins Nov 25, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 25, 2025 17:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. and removed pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. labels Nov 25, 2025
@mrgrain mrgrain changed the title chore(mixins-preview): codegen for vended logs mixins feat(mixins-preview): LogDelivery Mixins for x services Nov 25, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mrgrain mrgrain changed the title feat(mixins-preview): LogDelivery Mixins for x services feat(mixins-preview): adds LogDelivery Mixins for 52 resources Nov 26, 2025
@mrgrain mrgrain force-pushed the vendedlogs-codegen branch 2 times, most recently from d3fbc92 to 0fedf86 Compare November 26, 2025 00:51
@mrgrain mrgrain changed the title feat(mixins-preview): adds LogDelivery Mixins for 52 resources feat(mixins-preview): adds LogDelivery Mixins for 47 resources Nov 26, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 26, 2025 02:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain mrgrain marked this pull request as ready for review November 26, 2025 02:41
@mrgrain mrgrain added pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. and removed pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. labels Nov 26, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 26, 2025
@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Nov 26, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 5 seconds in the queue, with no time waiting for CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6607ce9 into main Nov 26, 2025
51 of 52 checks passed
@mergify mergify bot deleted the vendedlogs-codegen branch November 26, 2025 06:34
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK contribution/core This is a PR that came from AWS. p2 pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants