fix(core): temp cleanup does not work with jest #36226
Conversation
Our temporary cleanup fix submitted in #36043 doesn't work for tests run with `jest`, because `jest` suppresses the standard Node `exit` event, causing the cleanup to never run. Instead, we introduce a new public static function which people using `jest` can call: ```ts afterAll(CloudAssembly.cleanupTemporaryDirectories); ``` As well as a convenience script to automatically inject this handler into all jest tests: ``` $ jest --setupFilesAfterEnv aws-cdk-lib/testhelpers/jest-autoclean ``` Once this PR has been merged and released we will add the above to all CLI init templates. Closes #802, hopefully for good.
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Merge Queue Status
✅ The pull request has been merged This pull request spent 28 minutes 27 seconds in the queue, including 28 minutes 4 seconds waiting for CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
Our temporary cleanup fix submitted in #36043 doesn't work for tests run with
jest, becausejestsuppresses the standard Nodeexitevent, causing the cleanup to never run.Instead, we introduce a new public static function which people using
jestcan call:As well as a convenience script to automatically inject this handler into all jest tests:
Once this PR has been merged and released we will add the above to all CLI init templates.
Closes #802, hopefully for good.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license