-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(aws-cdk-lib): add arnFor<ResourceName> for 47 more resources
#36231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
5e6c194 to
2c3d8af
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
2c3d8af to
d79cbcc
Compare
d79cbcc to
0528641
Compare
arnForResource for x more resourcesarnForResource for 47 more resources
arnForResource for 47 more resourcesarnForResource for 47 more resources
arnForResource for 47 more resourcesarnFor<ResourceName> for 47 more resources
arnFor<ResourceName> for 47 more resourcesarnFor<ResourceName> for 47 more resources
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Today, out of
1512resources,892have anarnFor${Resource}getter function (~58%).The reasons are varied, but it comes done to us not being able to identify the required resource properties in an automated way.
Description of changes
We are adding a few additional heuristics to the matching:
37additional resources)ARN(all caps). (9additional resources)AgentRuntimeinstead of the expectedRuntime. We extract this prefix from a primary identifier if it is ending inId. (2additional resources)This brings our total count to
939or~62%. A little better!PR also includes a major refactor of how reference props and now arn getters are organized. A lot of code depends on this information, so best to centralize the logic for it.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing and additional tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license