-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(ec2): add interface vpc endpoints #36236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| public static readonly ACCOUNT_MANAGEMENT = new InterfaceVpcEndpointAwsService('account'); | ||
| public static readonly ACM = new InterfaceVpcEndpointAwsService('acm'); | ||
| public static readonly ACM_FIPS = new InterfaceVpcEndpointAwsService('acm-fips'); | ||
| public static readonly ACM_PCA_FIPS = new InterfaceVpcEndpointAwsService('acm-pca-fips'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acm-pca already exists as PRIVATE_CERTIFICATE_AUTHORITY, following the naming it should be: PRIVATE_CERTIFICATE_AUTHORITY_FIPS
| public static readonly PRIVATE_CERTIFICATE_AUTHORITY = new InterfaceVpcEndpointAwsService('acm-pca'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've updated it.
Pull request has been modified.
|
@leonmk-aws Thank you for your review! I've addressed your comment. |
|
||||||||||||||
|
||||||||||||||
leonmk-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you !
Merge Queue Status✅ The pull request has been merged This pull request spent 59 minutes 58 seconds in the queue, including 39 minutes 23 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
Description of changes
Add some interface VPC endpoints.
Describe any new or updated permissions being added
None
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license