Skip to content

Conversation

@badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Nov 28, 2025

Issue # (if applicable)

None

Reason for this change

Description of changes

Add some interface VPC endpoints.

  • ACM
  • ACM_FIPS
  • ACM_PCA_FIPS
  • BEDROCK_FIPS
  • BEDROCK_RUNTIME_FIPS
  • ECR_PUBLIC
  • S3_VECTORS

Describe any new or updated permissions being added

None

Description of how you validated changes

aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames

    "com.amazonaws.us-east-1.acm",
    "com.amazonaws.us-east-1.acm-fips",
    "com.amazonaws.us-east-1.acm-pca",
    "com.amazonaws.us-east-1.acm-pca-fips"
 "com.amazonaws.us-east-1.bedrock-fips",
    "com.amazonaws.us-east-1.bedrock-runtime-fips",
    "com.amazonaws.us-east-1.ecr-public.api",
    "com.amazonaws.us-east-1.s3vectors",

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 28, 2025 12:12
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 28, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 28, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 29, 2025
@leonmk-aws leonmk-aws self-assigned this Dec 3, 2025
public static readonly ACCOUNT_MANAGEMENT = new InterfaceVpcEndpointAwsService('account');
public static readonly ACM = new InterfaceVpcEndpointAwsService('acm');
public static readonly ACM_FIPS = new InterfaceVpcEndpointAwsService('acm-fips');
public static readonly ACM_PCA_FIPS = new InterfaceVpcEndpointAwsService('acm-pca-fips');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acm-pca already exists as PRIVATE_CERTIFICATE_AUTHORITY, following the naming it should be: PRIVATE_CERTIFICATE_AUTHORITY_FIPS

public static readonly PRIVATE_CERTIFICATE_AUTHORITY = new InterfaceVpcEndpointAwsService('acm-pca');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've updated it.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 3, 2025
@mergify mergify bot dismissed leonmk-aws’s stale review December 3, 2025 11:59

Pull request has been modified.

@badmintoncryer
Copy link
Contributor Author

@leonmk-aws Thank you for your review! I've addressed your comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results with resolved templates0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

Copy link
Contributor

@leonmk-aws leonmk-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2025

Merge Queue Status

✅ The pull request has been merged

This pull request spent 59 minutes 58 seconds in the queue, including 39 minutes 23 seconds running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 5, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1cc503a into aws:main Dec 5, 2025
20 of 22 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants