Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added source field option for define-index-field command under CloudSearch #6045

Conversation

akhill10
Copy link
Contributor

Fixes Issue #6017

Description of changes:
Added [--source-field <value>] option for the define-index-field command under CloudSearch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@justindho justindho linked an issue Jun 1, 2022 that may be closed by this pull request
@justindho justindho added feature-request A feature should be added or improved. cloudsearch community labels Jun 1, 2022
@justindho justindho force-pushed the feature/cloudsearch/define-index-field_SourceField_Option branch from e3d4031 to ccbe2a4 Compare June 1, 2022 20:30
@codecov-commenter
Copy link

Codecov Report

Merging #6045 (e3d4031) into develop (c71d1df) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head e3d4031 differs from pull request most recent head ccbe2a4. Consider uploading reports for the commit ccbe2a4 to get more accurate results

@@             Coverage Diff             @@
##           develop    #6045      +/-   ##
===========================================
- Coverage    92.88%   92.66%   -0.23%     
===========================================
  Files          204      204              
  Lines        16344    16188     -156     
===========================================
- Hits         15181    15000     -181     
- Misses        1163     1188      +25     
Impacted Files Coverage Δ
awscli/customizations/cloudsearch.py 91.30% <ø> (ø)
awscli/customizations/ecs/deploy.py 60.31% <0.00%> (-32.81%) ⬇️
awscli/customizations/configure/list.py 89.79% <0.00%> (-2.05%) ⬇️
awscli/utils.py 93.38% <0.00%> (-1.91%) ⬇️
.../customizations/datapipeline/createdefaultroles.py 84.72% <0.00%> (-1.00%) ⬇️
awscli/customizations/codeartifact/login.py 97.48% <0.00%> (-0.36%) ⬇️
awscli/customizations/configure/writer.py 99.04% <0.00%> (-0.10%) ⬇️
awscli/argprocess.py 94.28% <0.00%> (-0.07%) ⬇️
...customizations/cloudformation/artifact_exporter.py 98.65% <0.00%> (-0.07%) ⬇️
awscli/clidriver.py 95.94% <0.00%> (-0.04%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71d1df...ccbe2a4. Read the comment docs.

Copy link
Contributor

@justindho justindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pawanakhil!

@justindho justindho merged commit dc7c268 into aws:develop Jun 1, 2022
@justindho justindho added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Jun 1, 2022
@justindho justindho added released and removed pending-release This issue will be fixed by an approved PR that hasn't been released yet. labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloudsearch community feature-request A feature should be added or improved. released
Projects
Development

Successfully merging this pull request may close these issues.

Cloudsearch define-index-field - source field option
3 participants