Add a Global Options section to help docs #7153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hssyoo
commented
Aug 1, 2022
| 'building-top-level-params', | ||
| 'building-command-table.main', |
There was a problem hiding this comment.
I had to change the order of these events because the global arg table must be built as part of the _build_builtin_commands method which gets run before the session emits a building-command-table.main event.
|
Closing this in favor of #7157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a lot of requests from users to include global options in a command's help page. The changes in this PR passes the global args table created once by the
CLIDriverto the help commands that generate help docs. The global args table is used to generate a newGlobal Optionssection in the help docs.The changes are currently only applied to standard commands, and does not include customizations.