From c2f52dee4d6f52a4066b34eb60bfa5db34e724cf Mon Sep 17 00:00:00 2001 From: Noah Beard Date: Wed, 13 Jul 2022 16:21:23 -0400 Subject: [PATCH 1/2] Update CONTRIBUTING to reflect how CI works in our repos --- documents/CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/documents/CONTRIBUTING.md b/documents/CONTRIBUTING.md index a0a28e202..cef884540 100644 --- a/documents/CONTRIBUTING.md +++ b/documents/CONTRIBUTING.md @@ -34,7 +34,8 @@ To send us a pull request, please: 3. Ensure local tests pass. 4. Commit to your fork using clear commit messages. 5. Send us a pull request, answering any default questions in the pull request interface. -6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation. +6. Wait for a repository collaborator to look at your PR, run it in CI, test, and review. If additional changes or discussion is needed, a contributor will get back to you, so please stay invovled in the conversation. + * Note: PRs from forks will not run in CI automatically for security reasons. If you make a PR and see that CI is left pending, this is normal and expected. GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and [creating a pull request](https://help.github.com/articles/creating-a-pull-request/). From 3715730f41db34009c38b45dfa240aa93cd630fc Mon Sep 17 00:00:00 2001 From: Noah Beard Date: Thu, 14 Jul 2022 13:18:27 -0400 Subject: [PATCH 2/2] Adjusted wording --- documents/CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/documents/CONTRIBUTING.md b/documents/CONTRIBUTING.md index cef884540..d1704be51 100644 --- a/documents/CONTRIBUTING.md +++ b/documents/CONTRIBUTING.md @@ -34,8 +34,8 @@ To send us a pull request, please: 3. Ensure local tests pass. 4. Commit to your fork using clear commit messages. 5. Send us a pull request, answering any default questions in the pull request interface. -6. Wait for a repository collaborator to look at your PR, run it in CI, test, and review. If additional changes or discussion is needed, a contributor will get back to you, so please stay invovled in the conversation. - * Note: PRs from forks will not run in CI automatically for security reasons. If you make a PR and see that CI is left pending, this is normal and expected. +6. Wait for a repository collaborator to look at your pull request, run the automated tests, and review. If additional changes or discussion is needed, a collaborator will get back to you, so please stay involved in the conversation. + * Note: pull requests from forks will not run the automated tests without collaborator involvement for security reasons. If you make a pull request and see that the tests are pending, this is normal and expected. GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and [creating a pull request](https://help.github.com/articles/creating-a-pull-request/).