diff --git a/aws_lambda_builders/workflows/nodejs_npm_esbuild/esbuild.py b/aws_lambda_builders/workflows/nodejs_npm_esbuild/esbuild.py index 173d22e67..97acd7f0e 100644 --- a/aws_lambda_builders/workflows/nodejs_npm_esbuild/esbuild.py +++ b/aws_lambda_builders/workflows/nodejs_npm_esbuild/esbuild.py @@ -116,11 +116,7 @@ def run(self, args, cwd=None): ] # Multi-value types (--external:axios --external:aws-sdk) -SUPPORTED_ESBUILD_APIS_MULTI_VALUE = [ - "external", - "loader", - "out_extension", -] +SUPPORTED_ESBUILD_APIS_MULTI_VALUE = ["external", "loader", "out_extension", "banner"] class EsbuildCommandBuilder: diff --git a/tests/unit/workflows/nodejs_npm_esbuild/test_esbuild.py b/tests/unit/workflows/nodejs_npm_esbuild/test_esbuild.py index 624cef36e..6181f9f8d 100644 --- a/tests/unit/workflows/nodejs_npm_esbuild/test_esbuild.py +++ b/tests/unit/workflows/nodejs_npm_esbuild/test_esbuild.py @@ -226,7 +226,14 @@ def test_builds_args_from_config(self, osutils_mock): @patch("aws_lambda_builders.workflows.nodejs_npm.utils.OSUtils") def test_combined_builder_with_dependencies(self, osutils_mock): - bundler_config = {"entry_points": ["x.js"], "loader": [".proto=text", ".json=js"], "format": "esm"} + bundler_config = { + "entry_points": ["x.js"], + "loader": [".proto=text", ".json=js"], + "format": "esm", + "banner": [ + "js=\"import { createRequire } from 'module'; const require = createRequire(import.meta.url);\"" + ], + } args = ( EsbuildCommandBuilder("scratch", "artifacts", bundler_config, osutils_mock, "") .build_entry_points() @@ -246,6 +253,7 @@ def test_combined_builder_with_dependencies(self, osutils_mock): "--format=esm", "--loader:.proto=text", "--loader:.json=js", + "--banner:js=\"import { createRequire } from 'module'; const require = createRequire(import.meta.url);\"", ], )