From f92b28fcb428a398397fb71d95376c13e09b25f5 Mon Sep 17 00:00:00 2001 From: Raymond Wang <14915548+wchengru@users.noreply.github.com> Date: Wed, 11 Aug 2021 08:56:50 -0700 Subject: [PATCH 1/3] Add ECR credentials for windows test --- appveyor-windows.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/appveyor-windows.yml b/appveyor-windows.yml index 730d24cfef..b631a522ba 100644 --- a/appveyor-windows.yml +++ b/appveyor-windows.yml @@ -77,6 +77,10 @@ install: test_script: # Reactivate virtualenv before running tests + - ps: " + If ((Test-Path env:BY_CANARY) -And (Test-Path env:DOCKER_USER) -And (Test-Path env:DOCKER_PASS)){ + echo Logging in Public ECR; aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws; + }" - "git --version" - "venv\\Scripts\\activate" - "docker system prune -a -f" From 86d1af78e77f21a633abcffd96c045b73fc8a5ba Mon Sep 17 00:00:00 2001 From: Raymond Wang <14915548+wchengru@users.noreply.github.com> Date: Wed, 11 Aug 2021 14:00:04 -0700 Subject: [PATCH 2/3] Remove the dockerhub env vars --- appveyor-windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor-windows.yml b/appveyor-windows.yml index b631a522ba..aa4e99a270 100644 --- a/appveyor-windows.yml +++ b/appveyor-windows.yml @@ -78,7 +78,7 @@ install: test_script: # Reactivate virtualenv before running tests - ps: " - If ((Test-Path env:BY_CANARY) -And (Test-Path env:DOCKER_USER) -And (Test-Path env:DOCKER_PASS)){ + If (Test-Path env:BY_CANARY){ echo Logging in Public ECR; aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws; }" - "git --version" From eb7ad7e1e0fd12c076590afa4a767e2f62f89aaf Mon Sep 17 00:00:00 2001 From: Raymond Wang <14915548+wchengru@users.noreply.github.com> Date: Wed, 11 Aug 2021 15:26:33 -0700 Subject: [PATCH 3/3] install aws cli in the windows test jobs --- appveyor-windows.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/appveyor-windows.yml b/appveyor-windows.yml index aa4e99a270..8f54e3dacb 100644 --- a/appveyor-windows.yml +++ b/appveyor-windows.yml @@ -66,6 +66,9 @@ install: # Actually install SAM CLI's dependencies - "pip install -e \".[dev]\"" + # Install aws cli + - "pip install awscli" + # Switch to Docker Linux containers - ps: Switch-DockerLinux