Skip to content

remove arbitrary response read timeout in kinesis GetRecords #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2025
Merged

remove arbitrary response read timeout in kinesis GetRecords #3221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53f01b9
remove bad kinesis customization
lucix-aws Oct 29, 2025
b09a48a
regenerate
lucix-aws Oct 29, 2025
8fa42b5
changelog
lucix-aws Oct 29, 2025
2052027
update snapshot
lucix-aws Oct 29, 2025
a886f26
deprecate timeout read closer
lucix-aws Oct 29, 2025
22b1da2
changelog
lucix-aws Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changelog/1f03d280f30349f1822b03d3e6a29fec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "1f03d280-f303-49f1-822b-03d3e6a29fec",
"type": "bugfix",
"description": "Deprecate http.AddResponseReadTimeoutMiddleware.",
"modules": [
"."
]
}
8 changes: 8 additions & 0 deletions .changelog/8cb021f3ad794653afac4d9b2d23827f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "8cb021f3-ad79-4653-afac-4d9b2d23827f",
"type": "bugfix",
"description": "Remove arbitrary read timeout on GetRecords which was causing response read panic. See #2752.",
"modules": [
"service/kinesis"
]
}
5 changes: 5 additions & 0 deletions aws/transport/http/timeout_read_closer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ func (r *timeoutReadCloser) Close() error {

// AddResponseReadTimeoutMiddleware adds a middleware to the stack that wraps the
// response body so that a read that takes too long will return an error.
//
// Deprecated: This API was previously exposed to customize behavior of the
// Kinesis service. That customization has been removed and this middleware's
// implementation can cause panics within the standard library networking loop.
// See #2752.
func AddResponseReadTimeoutMiddleware(stack *middleware.Stack, duration time.Duration) error {
return stack.Deserialize.Add(&readTimeout{duration: duration}, middleware.After)
}
Expand Down
51 changes: 0 additions & 51 deletions ...are/amazon/smithy/aws/go/codegen/customization/service/kinesis/KinesisCustomizations.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...n/resources/META-INF/services/software.amazon.smithy.go.codegen.integration.GoIntegration
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ software.amazon.smithy.aws.go.codegen.customization.service.s3.S3ContentSHA256He
software.amazon.smithy.aws.go.codegen.customization.service.s3.BackfillS3ObjectSizeMemberShapeType
software.amazon.smithy.aws.go.codegen.customization.service.machinelearning.MachineLearningCustomizations
software.amazon.smithy.aws.go.codegen.customization.service.s3.S3AcceptEncodingGzip
software.amazon.smithy.aws.go.codegen.customization.service.kinesis.KinesisCustomizations
software.amazon.smithy.aws.go.codegen.customization.service.s3.S3ErrorWith200Status
software.amazon.smithy.aws.go.codegen.customization.service.route53.Route53Customizations
software.amazon.smithy.aws.go.codegen.customization.PresignURLAutoFill
Expand Down
5 changes: 0 additions & 5 deletions service/kinesis/api_op_GetRecords.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions service/kinesis/internal/customizations/readtimeout.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion service/kinesis/snapshot/api_op_GetRecords.go.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,5 @@ GetRecords
InterceptBeforeDeserialization
AddTimeOffsetMiddleware
RecordResponseTiming
ReadResponseTimeout
RequestResponseLogger
InterceptTransmit
Loading