Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageBuilder Component missing "type" attribute #3161

Closed
Dogers opened this issue Feb 22, 2020 · 3 comments
Closed

ImageBuilder Component missing "type" attribute #3161

Dogers opened this issue Feb 22, 2020 · 3 comments
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@Dogers
Copy link

Dogers commented Feb 22, 2020

Version of AWS SDK for Go?

master?

What issue did you see?

Per https://docs.aws.amazon.com/imagebuilder/latest/APIReference/API_Component.html
Component has a "type" attribute which should take either BUILD or TEST. These are set in the SDK(1), but the attribute isn't available(2) so is currently always defaulting to TEST when calling AWS.

Refs:
(1) https://github.com/aws/aws-sdk-go/blob/master/service/imagebuilder/api.go#L12362
(2) https://github.com/aws/aws-sdk-go/blob/master/service/imagebuilder/api.go#L5455

@Dogers
Copy link
Author

Dogers commented Feb 22, 2020

Actually sorry after poking about more in the files, it looks like it's specifically missing in CreateComponentRequest (1) and CreateComponent (2). The Component object (3) actually has the attribute, if I'm following this correctly?

Refs:
(1) https://github.com/aws/aws-sdk-go/blob/master/models/apis/imagebuilder/2019-12-02/api-2.json#L952
(2) https://github.com/aws/aws-sdk-go/blob/master/models/apis/imagebuilder/2019-12-02/api-2.json#L35
(3) https://github.com/aws/aws-sdk-go/blob/master/models/apis/imagebuilder/2019-12-02/api-2.json#L862

@diehlaws diehlaws self-assigned this Feb 26, 2020
@diehlaws diehlaws added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Feb 26, 2020
@diehlaws
Copy link
Contributor

Hi @Dogers, thanks for reaching out to us. You are correct regarding the type parameter being present in the Component object but not in the input for the CreateComponent and CreateComponentRequest calls.

Looking at the service's API Reference, the Component data type looks like it is only used in the response for a GetComponent call. It appears that only the input for ImportComponent supports providing the component's type. Unfortunately I'm not sufficiently familiar with the EC2 Image Builder service to determine why this is the case or if the CreateComponent call's input should include the type field. I'd suggest reaching out to our Premium Support team by opening a new technical support case under the EC2 Image Builder service for further support on the service end.

@diehlaws diehlaws added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Feb 26, 2020
@Dogers
Copy link
Author

Dogers commented Feb 26, 2020

I've had some time to play around in the console and from looking at what's created, I now believe the Type field is actually calculated from what's provided in the Data field, as there's build, validate, test, etc steps in it. Guess this is actually a non-issue!

@Dogers Dogers closed this as completed Feb 26, 2020
@diehlaws diehlaws removed their assignment Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

2 participants