Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE 2017-15095 and CVE-2018-7489 #1597

Closed
hosamaly opened this issue May 24, 2018 · 2 comments
Closed

Fix CVE 2017-15095 and CVE-2018-7489 #1597

hosamaly opened this issue May 24, 2018 · 2 comments
Labels
investigating This issue is being investigated and/or work is in progress to resolve the issue.

Comments

@hosamaly
Copy link

At the time of writing, the AWS SDK depends on jackson-databind v2.6.7.1. This version suffers from CVE 2017-15095 and CVE-2018-7489, both of which are critical vulnerabilities.

A fix for CVE 2017-15095 was backported to 2.6.7.x in FasterXML/jackson-databind#1945. However, it was never released. I'm also unaware of a backport of FasterXML/jackson-databind#1931.

hosamaly referenced this issue in FasterXML/jackson-databind May 24, 2018
@cowtowncoder
Copy link
Contributor

For what it is worth, the next (micro-)patch version with fixes to above-mentioned CVEs is 2.7.9.3.
And further up minor versions, 2.8.11.1 has both as well.

Potential risk of CVEs in question is discussed on:

https://medium.com/@cowtowncoder/on-jackson-cves-dont-panic-here-is-what-you-need-to-know-54cd0d6e8062

and I don't know if SDK uses either Default Typing or polymorphic types (via @JsonTypeInfo on property) with declared base type of java.lang.Object.

But I think many/most/all CVE tools are unable to assess actual risk wrt features used and simply assume there is a vulnerability just because someone may use specific feature(s) in question, so even if there were no problems, security tools are likely to flag dependency as risky.

@shorea shorea added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label May 24, 2018
@shorea
Copy link
Contributor

shorea commented May 26, 2018

We will be updating the README shortly about these CVEs. In short the SDK is not affected because we don't use polymorphic deserialization as @cowtowncoder explains above.

@shorea shorea closed this as completed May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating This issue is being investigated and/or work is in progress to resolve the issue.
Projects
None yet
Development

No branches or pull requests

3 participants