Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk to use exact dependecies for other aws-sdk package dependencies #1072

Closed
Amplifiyer opened this issue Apr 2, 2020 · 6 comments
Closed
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@Amplifiyer
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Now since aws-sdk has many packages that depend on each other and use loose version numbers (^ versions), clients using a particular version of aws-sdk-v3 clients may end up getting newer versions of transitive dependencies of aws-sdk-v3 if they don't use lock files or delete lock files.

Describe the solution you'd like
I'd like aws-sdk clients to use exact versions for all their other aws-sdk package dependencies (such that the closure of aws-sdk packages for a given version/release is always compatible)

This will ideally decouple aws-amplify (or other clients) to be always aware of any aws-sdk-v3 releases

@Amplifiyer Amplifiyer added the feature-request New feature or enhancement. May require GitHub community feedback. label Apr 2, 2020
@trivikr
Copy link
Member

trivikr commented Apr 9, 2020

CDK is also facing similar issue, and they've discussed this in aws/aws-cdk-rfcs#6

@Amplifiyer
Copy link
Contributor Author

@trivikr thanks for linking the issue. Can you summarize that issue and how JS-SDK can leverage that solution?

@trivikr
Copy link
Member

trivikr commented Apr 9, 2020

Can you summarize that issue and how JS-SDK can leverage that solution?

As posted in aws/aws-cdk-rfcs#122 (comment), the issue is a concern for CDK as it's a "framework" and mostly consumed by "CDK Apps". SDKs are mostly used as libraries where there's less dependency in-between clients.

We're evaluating the CDK RFC, and will provide more details.

@trivikr
Copy link
Member

trivikr commented Apr 9, 2020

Refs: aws/aws-cdk-rfcs#122 (comment)

The main reason the SDKs are bundled separately are to reduce the runtime footprint and that’s a legitimate concern when it comes to a library you link against.

@trivikr
Copy link
Member

trivikr commented Apr 27, 2020

Closing as we use exact dependencies from beta.5 onwards
https://github.com/aws/aws-sdk-js-v3/releases/tag/v1.0.0-beta.5

@trivikr trivikr closed this as completed Apr 27, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants