-
Notifications
You must be signed in to change notification settings - Fork 753
fix(sagemaker): singleton window bug #8385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
| const hyperPodEnv: NodeJS.ProcessEnv = { | ||
| AWS_REGION: region, | ||
| SESSION_ID: session || '', | ||
| SESSION_ID: hostname || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't this be session?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hostname also uses session but session is randomly generated in the presigned url and this is what's causing a new external window to be opened when the user tries to connect to the workspace.
After discussing with @edwardps, we decided to use a deterministic unique identifier for the hostname instead
| if (domain === '' && eksClusterArn) { | ||
| const { accountId, region, clusterName } = parseEKSClusterArn(eksClusterArn) | ||
| connectionType = 'sm_hp' | ||
| session = `${workspaceName}_${namespace}_${clusterName}_${region}_${accountId}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${workspaceName}_${namespace}
Please check the naming convention(limits) to confirm the characters allow by k8s can be accepted as ssh hostname.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added k8s naming convention validation
83cf892 to
9ec8341
Compare
9ec8341 to
b025fb0
Compare
Problem
Solution
feature/xbranches will not be squash-merged at release time.