Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii exist code is 0 even if there are compilation errors #441

Closed
eladb opened this issue Apr 8, 2019 · 0 comments
Closed

jsii exist code is 0 even if there are compilation errors #441

eladb opened this issue Apr 8, 2019 · 0 comments
Labels
bug This issue is a bug.

Comments

@eladb
Copy link
Contributor

eladb commented Apr 8, 2019

No description provided.

@eladb eladb added the bug This issue is a bug. label Apr 8, 2019
eladb pushed a commit that referenced this issue Apr 8, 2019
fix: exit with non-zero exit code if there are compilation errors
7a62197 
In #383 we modified the compiler to continue jsii validation despite
compilation errors but did not propagate the fact that there were
compilation errors.

This resulted in "jsii" exiting with a 0 exit code even in case
of errors.

Fixes #441
@eladb eladb mentioned this issue Apr 8, 2019
Merged
@eladb eladb closed this as completed in #442 Apr 8, 2019
eladb pushed a commit that referenced this issue Apr 8, 2019
fix: exit with non-zero exit code if there are compilation errors (#442)
6265bf6 
In #383 we modified the compiler to continue jsii validation despite
compilation errors but did not propagate the fact that there were
compilation errors.

This resulted in "jsii" exiting with a 0 exit code even in case
of errors.

Fixes #441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eladb