fix(jsii): excessive "exclude" in "tsconfig.json" #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where both `jsii.tsc.outDir` and `jsii.tsc.rootDir` are set, and `rootDir` happens to be a parent directory of `outDir`, the generated `exclude` would mathc all files from `rootDir`, resulting in an empty input set. This makes sure to not emit an `exclude` declaration for `outDir` in this case, so that input files do not get excluded.
eladb
suggested changes
Jun 15, 2020
| @@ -289,8 +289,12 @@ export class Compiler implements Emitter { | |||
| ], | |||
| exclude: [ | |||
| 'node_modules', | |||
| ...pi.excludeTypescript, | |||
There was a problem hiding this comment.
can we write a test for this?
|
The PR includes a test by way of jsii-calc-base-of-base... Are you looking for something else? |
eladb
approved these changes
Dec 10, 2020
|
What's up with this PR? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where both
jsii.tsc.outDirandjsii.tsc.rootDirare set, androotDirhappens to be a parent directory ofoutDir, the generatedexcludewould match all files fromrootDir, resulting in an empty input set.This makes sure to not emit an
excludedeclaration foroutDirin this case, so that input files do not get excluded.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.