Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosetta): correctly emit multi-line string literals #2419

Merged
merged 3 commits into from
Jan 26, 2021

Conversation

RomainMuller
Copy link
Contributor

This fixes hox multi-line string literals and template expressions are
rendered in all supported languages, leveraging idiomatic multi-line
literals where possible (i.e: everywhere but Java).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This fixes hox multi-line string literals and template expressions are
rendered in all supported languages, leveraging idiomatic multi-line
literals where possible (i.e: everywhere but Java).
@RomainMuller RomainMuller added bug This issue is a bug. effort/small Small work item – less than a day of effort module/sampiler Issues affecting the `jsii-sampiler` module contribution/core This is a PR that came from AWS. labels Jan 13, 2021
@RomainMuller RomainMuller requested a review from a team January 13, 2021 11:54
@RomainMuller RomainMuller self-assigned this Jan 13, 2021
@RomainMuller RomainMuller added this to the 🎆 January Release milestone Jan 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2021

Merging (with squash)...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
  • Commit ID: f554fdd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a30a996 into main Jan 26, 2021
@mergify mergify bot deleted the rmuller/rosetta-escapes branch January 26, 2021 17:58
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort module/sampiler Issues affecting the `jsii-sampiler` module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants