Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pacmak): multiple go (and python) issues #2622

Merged
merged 5 commits into from
Mar 1, 2021
Merged

fix(pacmak): multiple go (and python) issues #2622

merged 5 commits into from
Mar 1, 2021

Commits on Feb 28, 2021

  1. fix(pacmak): multiple go compilation errors 

    The `go build` command we run during pacmak did not descend into submodules. After adding `./...` to the `go build` command, a few other issues were surfaced related to static member handling. 

The common issue was that `GoClass` had two separate lists (for static and non-static methods/props). This caused various places in the implementation to only take into account non-static members. Added a new list called `members` which collected both static and non-static members and used it in the various dependency props.

An empty module in Python (with only submodules) will result in an empty `__all__` list which yields a MyPy error.

Fixes #2618 - go build does not build submodule directories
Fixes #2619 - go/python module with only submodules (no direct types) fails compilation
Fixes #2620 - go missing imports if class includes only static members
Fixes #2621 - invalid go imports when types referenced by static members
    Elad Ben-Israel committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    b47a4b2 View commit details
    Browse the repository at this point in the history

  2. Update index.ts

    Elad Ben-Israel committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    a848899 View commit details
    Browse the repository at this point in the history

  3. update snapshots

    Elad Ben-Israel committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    8723644 View commit details
    Browse the repository at this point in the history

  4. update snapshots

    Elad Ben-Israel committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    479b1a7 View commit details
    Browse the repository at this point in the history

  5. update snapshots

    Elad Ben-Israel committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    f2d7f5f View commit details
    Browse the repository at this point in the history