Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosetta): fix translation of ! and === operators #3052

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 11, 2021

These were translated as ~ and not translated at all, respectively.

Fixes #2993.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

These were translated as `~` and not translated at all, respectively.

Fixes #2993.
@rix0rrr rix0rrr requested a review from a team October 11, 2021 08:04
@rix0rrr rix0rrr self-assigned this Oct 11, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Oct 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Merging (with squash)...

@mergify mergify bot merged commit 72b9b98 into main Oct 11, 2021
@mergify mergify bot deleted the huijbers/operators branch October 11, 2021 11:57
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(rosetta) Bugs in Python translation
2 participants