Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jsii-reflect now renders union candidates sorted #4005

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

RomainMuller
Copy link
Contributor

Sorting union members guarantees a uniform order is always presented, making it easier to visually compare assemblies (or pre-process them with jsii-reflect before using a textual diff tool). This also effects how jsii-diff compares assemblies, removing many false positives in breaking change detection.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorting union members guarantees a uniform order is always presented,
making it easier to visually compare assemblies (or pre-process them
with `jsii-reflect` before using a textual `diff` tool). This also
effects how `jsii-diff` compares assemblies, removing many false
positives in breaking change detection.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

Merging (with squash)...

@mergify mergify bot merged commit 1fd6cde into main Mar 14, 2023
@mergify mergify bot deleted the rmuller/sort-union-jsii-reflect branch March 14, 2023 12:19
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants