Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): Bump pip from 23.0.1 to 23.1.2 in /packages/jsii-pacmak/test/generated-code #4072

Merged
merged 3 commits into from
May 12, 2023
Merged

chore(deps-dev): Bump pip from 23.0.1 to 23.1.2 in /packages/jsii-pacmak/test/generated-code #4072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f38937
chore(deps-dev): Bump pip in /packages/jsii-pacmak/test/generated-code
dependabot[bot] May 11, 2023
c2deca4
fixing based on changes to pip version
corymhall May 12, 2023
cf23f77
Merge branch 'main' into dependabot/pip/packages/jsii-pacmak/test/gen…
mergify[bot] May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/jsii-pacmak/test/generated-code/harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,15 @@ async function runPacmak(

export async function preparePythonVirtualEnv({
install = [],
installOptions = [],
venvDir = __dirname,
systemSitePackages = true,
}: {
install?: readonly string[];
// some options like `--config-settings` should only be
// passed once. If they are passed multiple times
// then it registers as an array with multiple values
installOptions?: readonly string[];
venvDir?: string;
systemSitePackages?: boolean;
} = {}) {
Expand Down Expand Up @@ -345,6 +350,7 @@ export async function preparePythonVirtualEnv({
'pip',
'install',
'--no-input',
...installOptions,
// Additional install parameters
...install,
// Note: this resolution is a little ugly, but it's there to avoid creating a dependency cycle
Expand Down
4 changes: 3 additions & 1 deletion packages/jsii-pacmak/test/generated-code/python-pyright.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,13 @@ beforeAll(async () => {
install: TEST_PACKAGES.flatMap(({ moduleName }) => [
'-e',
JSON.stringify(path.join(pythonSource, moduleName, TargetName.PYTHON)),
]),
installOptions: [
// setuptools >=64 requires this
// https://github.com/pypa/setuptools/issues/3518
'--config-settings',
'editable_mode=strict',
]),
],
venvDir: pythonSource,
systemSitePackages: false, // Interferes with pyright resolutions...
});
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-pacmak/test/generated-code/requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
mypy==1.3.0
pip==23.0.1 # required to use --config-settings
pip==23.1.2 # required to use --config-settings