Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure alias version isn't dropped round-trip #6777

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: ensure alias version isn't dropped round-trip #6777

merged 1 commit into from
Aug 21, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Aug 15, 2024

Fixes #6776

Description
Ensures that the version pin for an alias is maintained via a compatibility annotation applied to the v1beta1 nodeclass.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner August 15, 2024 23:45
@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 45766f1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c384b53fd0850008673586
😎 Deploy Preview https://deploy-preview-6777--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Aug 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10458293137

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 79.303%
Totals Coverage Status
Change from base Build 10446194716: 0.04%
Covered Lines: 5935
Relevant Lines: 7484
💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Aug 16, 2024
View reviewed changes
pkg/apis/v1/ec2nodeclass_conversion_test.go Outdated Show resolved Hide resolved
@jonathan-innis
Copy link
Contributor

Might be related to #6792 as well

@jmdeal jmdeal enabled auto-merge (squash) August 20, 2024 22:02
jonathan-innis
jonathan-innis approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 325423e into aws:main Aug 21, 2024
15 checks passed
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 12, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
04caec1
@jmdeal jmdeal mentioned this pull request Sep 12, 2024
Merged
3 tasks
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 12, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
0984e83
rschalo pushed a commit that referenced this pull request Sep 12, 2024
@jmdeal
cherry-pick(1.0.x): fix: ensure alias version isn't dropped round-trip (
c894c32 
#6777) (#6993)
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 12, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
546218a
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 12, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
67e9e5f
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 12, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
680629b
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 12, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
f5555ed
This was referenced Sep 12, 2024
Merged
Merged
Merged
Merged
Merged
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 12, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
8b42e5a
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 13, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
e3ac507
jmdeal added a commit that referenced this pull request Sep 17, 2024
@jmdeal
cherry-pick(0.33.x): fix: ensure alias version isn't dropped round-tr…
efd4151 
…ip (#6777) (#7002)
jmdeal added a commit that referenced this pull request Sep 17, 2024
@jmdeal
cherry-pick(0.36.x): fix: ensure alias version isn't dropped round-tr…
6528a39 
…ip (#6777) (#7000)
jmdeal added a commit that referenced this pull request Sep 17, 2024
@jmdeal
cherry-pick(0.35.x): fix: ensure alias version isn't dropped round-tr…
2430f7a 
…ip (#6777) (#6999)
jmdeal added a commit that referenced this pull request Sep 17, 2024
@jmdeal
cherry-pick(0.37.x): fix: ensure alias version isn't dropped round-tr…
04cfa57 
…ip (#6777) (#7005)
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 19, 2024
@jmdeal
fix: ensure alias version isn't dropped round-trip (aws#6777)
67eb893
jmdeal added a commit that referenced this pull request Sep 23, 2024
@jmdeal
cherry-pick(0.34.x): fix: ensure alias version isn't dropped round-tr…
85a0b2a 
…ip (#6777) (#7001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias version pin is dropped when storage version is v1beta1
3 participants
@jmdeal @coveralls @jonathan-innis