Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update EBS CSI topology example and note #6924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ConnorJC3
Copy link

Fixes #N/A

Description

As of v1.33.0, the EBS CSI Driver no longer creates volumes with a custom topology key (topology.ebs.csi.aws.com/zone), and instead uses the standard key (topology.kubernetes.io/zone).

Update the example in the docs, and change the note to include the cutoff version.

How was this change tested?

Largely N/A, docs change. Manually applied the example manifests to a cluster running Karpenter and the EBS CSI Driver to confirm validity.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Connor Catlett <conncatl@amazon.com>
@ConnorJC3 ConnorJC3 requested a review from a team as a code owner September 4, 2024 17:49
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ac80d75
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66d89d94d7dc810008216f21
😎 Deploy Preview https://deploy-preview-6924--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10706882821

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.055%

Totals Coverage Status
Change from base Build 10706395738: 0.03%
Covered Lines: 5514
Relevant Lines: 6639

💛 - Coveralls

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants