Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(0.33.x): fix: ensure alias version isn't dropped round-trip (#6777) #7002

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Sep 12, 2024

Fixes #N/A

Description
Cherry picks #6777

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10840781262

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 77.306%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.37%
Totals Coverage Status
Change from base Build 10782728468: 0.09%
Covered Lines: 5314
Relevant Lines: 6874

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit efd4151 into aws:release-v0.33.x Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants