fix(s2n-quic-transport): Unmap peer address when determining MTU probe size #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # quic/s2n-quic-core/src/recovery/bbr.rs
camshaft
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I noticed that server and client MTU probes were of different sizes in our interop tests, the server being 20 bytes smaller than the client. This is due to the server listening on a dual-mode socket (IPv4 and IPv6). When calculating the MTU probe size, we were interpreting IPv4 addresses that had been mapped to IPv6 as IPv6 addresses, resulting in a smaller MTU probe. This change unmaps the peer address so that the MTU probe reaches its maximum allowed size when listening on dual-mode sockets.
Testing:
Added unit test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.