feat(s2n-quic-qns): add client perf implementation #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
reviewed
Jun 3, 2022
Comment on lines
38
to
-43
| #[structopt(long, default_value)] | ||
| tls: TlsProviders, |
There was a problem hiding this comment.
this was used to explicitly enable rustls vs s2n-tls. it breaks perf and it is also used in run_endpoint.sh which is used in interop to select the tls provider
There was a problem hiding this comment.
ah right. i will remove it there since i don't think the differences are all that interesting.
There was a problem hiding this comment.
ah right. i will remove it there since i don't think the differences are all that interesting.
camshaft
force-pushed
the
camshaft/perf-client
branch
2 times, most recently
from
ff2ca47
to
1448daa
Compare
camshaft
force-pushed
the
camshaft/perf-client
branch
from
1448daa
to
0b0b8f7
Compare
toidiu
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a perf client implementation to s2n-quic-qns. This initial version is basic but it at least gives us a perf client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.