Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Path is not app limited if more data is available to transmit (#1326)" #1350

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Jun 3, 2022

This reverts commit eb879b8.

Description of changes:

From the original PR:

The effect of this is there is some possibility for the congestion window to grow even if the application does not fully utilize the congestion window.

Based on the above behavior, the cwnd continues to grow, even when app-limited. This is incorrect behavior and can result in a large loss when the application is ready to send.

Call-outs:

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu toidiu marked this pull request as ready for review June 3, 2022 19:23
@toidiu toidiu enabled auto-merge (squash) June 3, 2022 19:23
@toidiu toidiu merged commit 66a695a into main Jun 3, 2022
@toidiu toidiu deleted the camshaft/app-limited-revert branch June 3, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants