feat(s2n-quic-transport): Support de-duplicating concurrent connections to the same peer #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
force-pushed
the
dedup-connections
branch
from
50f4f97
to
c517b0b
Compare
WesleyRosenblum
changed the title
camshaft
reviewed
Jul 16, 2024
Mark-Simulacrum
force-pushed
the
dedup-connections
branch
2 times, most recently
from
0c9e33b
to
8aa2274
Compare
Mark-Simulacrum
force-pushed
the
dedup-connections
branch
from
8aa2274
to
7732637
Compare
camshaft
reviewed
Jul 17, 2024
Open connections can now be found when calling connect(), including in-flight connections. Currently this property is applied to *all* connections, the next commit will add support for configuring whether the application is interested in this support.
(No longer actually changed by previous commits, but seems worth the comment regardless to save future time).
Mark-Simulacrum
force-pushed
the
dedup-connections
branch
from
7732637
to
5260fc6
Compare
camshaft
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #2211
Description of changes:
This implements support for utilizing s2n-quic to track open (or pending open) connection handles, effectively de-duplicating requests to open a connection.
Call-outs:
HashMap<Connect, InternalId>. It's possible this could be made intrusive and save memory, though I'm not sure if the SNI and initial open SocketAddr are actually tracked within the connection state. This is purely an optimization though and shouldn't affect public API if we choose to apply it.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.